Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riscv: telink: merge zigbee fimware before process_binaries #365

Merged
merged 1 commit into from
Jan 10, 2025
Merged

riscv: telink: merge zigbee fimware before process_binaries #365

merged 1 commit into from
Jan 10, 2025

Conversation

pulin1103
Copy link
Collaborator

  • check zigbee firmware path.
  • merge zb fw into matter fw and sign it.

@pulin1103 pulin1103 requested a review from s07641069 as a code owner January 8, 2025 06:40
@github-actions github-actions bot added the config label Jan 8, 2025
s07641069
s07641069 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Owner

@s07641069 s07641069 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pulin1103
Code looks ok
But please take a look into /scripts/tools/telink/process_binaries.py
This script I created to replace dd command usage under CMake
It much user friendly and easy to use.
Under Matter upstream master we use only this script, no more dd commands for merging binaries.

@pulin1103 pulin1103 force-pushed the develop_dual_merge_zbfw branch from 81fa4ee to 0cbd515 Compare January 9, 2025 06:53
riscv: telink: merge zigbee fimware before process_binaries
4418497 
- check zigbee firmware path.
- merge zb fw into matter fw and sign it.

Signed-off-by: Zhenghuan Zhang <[email protected]>
@pulin1103 pulin1103 force-pushed the develop_dual_merge_zbfw branch from 0cbd515 to 4418497 Compare January 9, 2025 09:19
@pulin1103
Copy link
Collaborator Author

@s07641069
Thank you for your suggestion. To meet IKEA's requirements, the process_binaries script needs some modifications (time is tight). We will try to add the functionality of merging Zigbee firmware into the script later.

@andy-liu-telink andy-liu-telink merged commit 5b80f89 into develop_dual Jan 10, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengtai-telink fengtai-telink fengtai-telink left review comments

@damien0x0023 damien0x0023 damien0x0023 approved these changes

@s07641069 s07641069 s07641069 approved these changes

@andy-liu-telink andy-liu-telink andy-liu-telink approved these changes

@haiwentelink haiwentelink haiwentelink approved these changes

Assignees

@damien0x0023 damien0x0023

@pulin1103 pulin1103

Labels
config
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pulin1103 @damien0x0023 @s07641069 @andy-liu-telink @haiwentelink @fengtai-telink