Fix and test self-signed issuer #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix the name of the self-signed issuer in the annotation of the ingress. - Add test ensuring the certificates and ingresses and annotations are created as expeced - Fix broken tests for COSI RBAC resources Fixes: aquarist-labs/s3gw#655 Signed-off-by: Moritz Röhrich <[email protected]>
m-ildefons
added
kind/bug
PhanLe1010
reviewed
Aug 14, 2023
|
I tried this PR but it still failed when using |
giubacc
suggested changes
Aug 17, 2023
Add an override option for a custom TLS issuer that is not the letsencrypt issuer or the self-signed issuer. Signed-off-by: Moritz Röhrich <[email protected]>
Fix cluster-internal private issuer if a custom TLS issuer is specified. Signed-off-by: Moritz Röhrich <[email protected]>
|
@m-ildefons what's the status on this one, and how closely related to #119 is this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: aquarist-labs/s3gw#655