usergallery 3.0: Replace JPEG_TOOLKIT, drop polyfill + prettyphoto#189
Merged
usergallery 3.0: Replace JPEG_TOOLKIT, drop polyfill + prettyphoto#189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JPEG_TOOLKIT seems to be abandoned and does not work under PHP 8, which meant the exif tag display in image pages was not only broken, it broke the blog. Instead of using the toolkit this approach uses the core function
serendipity_getMetaData, which uses PHPsexif_read_datato get the data if available.This changes the keys of the exif tags though, and the approach of a settings string does not account for that scenario. I opted to not migrate the settings over, it would be too much work. Instead this sets a new default option string with the current keys.
Also drops a polyfill for
array_combine- the function exists since PHP 5. And removes the prettyphoto lightbox option, since the lightbox plugin also dropped that abandoned script in #179.