Skip to content

fix: #4298 loading components ignore prefers-reduced-motion #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tahmidbintaslim wants to merge 3 commits into
base: master
Choose a base branch
from
+40 −1
Open

fix: #4298 loading components ignore prefers-reduced-motion #4341

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fd258e
fix: #4298 loading components ignore prefers-reduced-motion
tahmidbintaslim Dec 12, 2025
5dba3fa
fix: slow down animations instead of disabling them for prefers-reduc…
tahmidbintaslim Dec 15, 2025
e839bc6
fix: correct layer specificity for .loading reduced-motion override
tahmidbintaslim Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions packages/daisyui/src/components/loading.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,37 @@
width: calc(var(--size-selector, 0.25rem) * 8);
}
}

@media (prefers-reduced-motion: reduce) {
.loading,
.loading-spinner {
@layer daisyui.l1.l2 {
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layer specificity is inconsistent with the original .loading class definition. The original .loading class at line 2 uses @layer daisyui.l1.l2.l3, but this reduced-motion override uses @layer daisyui.l1.l2. This means the reduced-motion styles may not have the correct specificity to override the original styles. The layer should be daisyui.l1.l2.l3 to match the original .loading definition.

Copilot uses AI. Check for mistakes.
mask-image: url("data:image/svg+xml,%3Csvg width='24' height='24' stroke='black' viewBox='0 0 24 24' xmlns='http://www.w3.org/2000/svg'%3E%3Ccircle cx='12' cy='12' r='9.5' fill='none' stroke-width='3' stroke-linecap='round' stroke-dasharray='42,150' stroke-dashoffset='-16'/%3E%3C/svg%3E");
}
}
.loading-dots {
@layer daisyui.l1.l2 {
mask-image: url("data:image/svg+xml,%3Csvg width='24' height='24' viewBox='0 0 24 24' xmlns='http://www.w3.org/2000/svg'%3E%3Ccircle cx='4' cy='12' r='3'/%3E%3Ccircle cx='12' cy='12' r='3'/%3E%3Ccircle cx='20' cy='12' r='3'/%3E%3C/svg%3E");
}
}
.loading-ring {
@layer daisyui.l1.l2 {
mask-image: url("data:image/svg+xml,%3Csvg width='44' height='44' viewBox='0 0 44 44' xmlns='http://www.w3.org/2000/svg' stroke='white'%3E%3Cg fill='none' fill-rule='evenodd' stroke-width='2'%3E%3Ccircle cx='22' cy='22' r='10' stroke-opacity='0.5'/%3E%3Ccircle cx='22' cy='22' r='20' stroke-opacity='0.25'/%3E%3C/g%3E%3C/svg%3E");
}
}
.loading-ball {
@layer daisyui.l1.l2 {
mask-image: url("data:image/svg+xml,%3Csvg width='24' height='24' viewBox='0 0 24 24' xmlns='http://www.w3.org/2000/svg'%3E%3Cellipse cx='12' cy='12' rx='4' ry='4'/%3E%3C/svg%3E");
}
}
.loading-bars {
@layer daisyui.l1.l2 {
mask-image: url("data:image/svg+xml,%3Csvg width='24' height='24' viewBox='0 0 24 24' xmlns='http://www.w3.org/2000/svg'%3E%3Crect x='1' y='1' width='6' height='22'/%3E%3Crect x='9' y='5' width='6' height='14' opacity='0.6'/%3E%3Crect x='17' y='3' width='6' height='18' opacity='0.8'/%3E%3C/svg%3E");
}
}
.loading-infinity {
@layer daisyui.l1.l2 {
mask-image: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' width='200px' height='200px' viewBox='0 0 100 100' preserveAspectRatio='xMidYMid'%3E%3Cpath fill='none' stroke='black' stroke-width='10' stroke-dasharray='205.271 51.318' d='M24.3 30C11.4 30 5 43.3 5 50s6.4 20 19.3 20c19.3 0 32.1-40 51.4-40C88.6 30 95 43.3 95 50s-6.4 20-19.3 20C56.4 70 43.6 30 24.3 30z' stroke-linecap='round' style='transform:scale(0.8);transform-origin:50px 50px'/%3E%3C/svg%3E");
}
}
}