Skip to content

fix(rootcolor): only apply the background image to :root; improve all root(color|scrolllock|scrollgutter) #4354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pdanpdan wants to merge 2 commits into
base: master
Choose a base branch
from
+23 −32
Open

fix(rootcolor): only apply the background image to :root; improve all root(color|scrolllock|scrollgutter) #4354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f52044
fix(rootcolor): only apply the background image to :root
pdanpdan Dec 19, 2025
1623cba
feat: improve separation of concerns for root(color|scrollgutter|scro…
pdanpdan Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/daisyui/src/base/rootcolor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
:root,
[data-theme] {
background: var(--page-scroll-bg, var(--root-bg));
background-color: var(--root-bg);
color: var(--color-base-content);
}

:root {
background-color: var(--page-scroll-bg, var(--root-bg));
}

:where(:root, [data-theme]) {
--root-bg: var(--color-base-100);
}
20 changes: 10 additions & 10 deletions packages/daisyui/src/base/rootscrollgutter.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
:root {
background: var(--page-scroll-bg, var(--root-bg));
--page-scroll-bg-on: linear-gradient(var(--root-bg, #0000), var(--root-bg, #0000))
--page-has-backdrop: var(--page-scroll-lock) 1;
--page-scroll-bg: var(--page-scroll-lock)
color-mix(in srgb, var(--root-bg, #0000), oklch(0% 0 0) calc(var(--page-has-backdrop, 0) * 40%));
--page-scroll-transition-on: background-color 0.3s ease-out;
background-image: var(--page-scroll-lock)
linear-gradient(var(--root-bg, #0000), var(--root-bg, #0000));

transition: var(--page-scroll-transition);
transition: var(--page-scroll-lock) background-color 0.3s ease-out;
animation: var(--page-scroll-lock) set-page-has-scroll forwards;
animation-timeline: var(--page-scroll-lock) scroll();

/* CSS if is not supported */
scrollbar-gutter: var(--page-scroll-gutter, unset);

/* CSS if is supported */
scrollbar-gutter: if(style(--page-has-scroll: 1): var(--page-scroll-gutter, unset) ; else: unset);
--page-has-scroll: initial;
scrollbar-gutter: var(--page-has-scroll) var(--page-scroll-lock) stable;
}

@keyframes set-page-has-scroll {
0%,
to {
--page-has-scroll: 1;
--page-has-scroll: ;
}
}
5 changes: 5 additions & 0 deletions packages/daisyui/src/base/rootscrolllock.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
:root {
--page-scroll-lock: initial;
--page-overflow: var(--page-scroll-lock) hidden;
}

/* force higher specificity */
:root:not(span) {
overflow: var(--page-overflow);
Expand Down
16 changes: 2 additions & 14 deletions packages/daisyui/src/components/drawer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,7 @@
}

:where(:root:has(&:checked)) {
--page-has-backdrop: 1;
--page-overflow: hidden;
--page-scroll-bg: var(--page-scroll-bg-on);
--page-scroll-gutter: stable;
--page-scroll-transition: var(--page-scroll-transition-on);
animation: set-page-has-scroll forwards;
animation-timeline: scroll();
--page-scroll-lock: ;
}
}

Expand Down Expand Up @@ -121,13 +115,7 @@
}

:root:has(&) {
--page-overflow: revert-layer;
--page-scroll-gutter: revert-layer;
--page-scroll-bg: revert-layer;
--page-scroll-transition: revert-layer;
--page-has-backdrop: revert-layer;
animation: revert-layer;
animation-timeline: revert-layer;
--page-scroll-lock: revert-layer;
}
}
}
Expand Down
8 changes: 1 addition & 7 deletions packages/daisyui/src/components/modal.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,7 @@
}

:root:has(&) {
--page-has-backdrop: 1;
--page-overflow: hidden;
--page-scroll-bg: var(--page-scroll-bg-on);
--page-scroll-gutter: stable;
--page-scroll-transition: var(--page-scroll-transition-on);
animation: set-page-has-scroll forwards;
animation-timeline: scroll();
--page-scroll-lock: ;
}
}

Expand Down