You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation keeps arbitrary ids when restricting the entries in a multiset to maxNumEntries if the counts are degenerate. It would make it easier to compare implementations if it would sort the degenerate ids in ascending order instead.
For example, the current implementation yields the result ids: [303 310 315], counts: [156 147 77] when summarising a label array with ids: [303 306 310 311 315], counts: [156 55 147 77 77] with maxNumEntries=3. I would expect to obtain ids: [303 310 311], counts: [156 147 77]instead.
For this change, one would only need to change the comparison here, I think.
The text was updated successfully, but these errors were encountered:
constantinpape
changed the title
Sort ids when restricting
Sort ids when restricting to maxNumEntries with degenerate counts
Sep 11, 2019
The current implementation keeps arbitrary ids when restricting the entries in a multiset to
maxNumEntries
if the counts are degenerate. It would make it easier to compare implementations if it would sort the degenerate ids in ascending order instead.For example, the current implementation yields the result
ids: [303 310 315], counts: [156 147 77]
when summarising a label array withids: [303 306 310 311 315], counts: [156 55 147 77 77]
withmaxNumEntries=3
. I would expect to obtainids: [303 310 311], counts: [156 147 77]
instead.For this change, one would only need to change the comparison here, I think.
The text was updated successfully, but these errors were encountered: