Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort ids when restricting to maxNumEntries with degenerate counts #14

Open
constantinpape opened this issue Sep 11, 2019 · 0 comments
Open

Comments

@constantinpape
Copy link

constantinpape commented Sep 11, 2019

The current implementation keeps arbitrary ids when restricting the entries in a multiset to maxNumEntries if the counts are degenerate. It would make it easier to compare implementations if it would sort the degenerate ids in ascending order instead.
For example, the current implementation yields the result ids: [303 310 315], counts: [156 147 77] when summarising a label array with ids: [303 306 310 311 315], counts: [156 55 147 77 77] with maxNumEntries=3. I would expect to obtain ids: [303 310 311], counts: [156 147 77]instead.

For this change, one would only need to change the comparison here, I think.

@constantinpape constantinpape changed the title Sort ids when restricting Sort ids when restricting to maxNumEntries with degenerate counts Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant