Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of N5Exception.N5IOException #17

Open
tpietzsch opened this issue May 16, 2023 · 0 comments
Open

Usage of N5Exception.N5IOException #17

tpietzsch opened this issue May 16, 2023 · 0 comments

Comments

@tpietzsch
Copy link
Collaborator

Several KeyValueAccess methods throw IOException.
Recently, N5Exception.N5IOException was introduced, and is now used in some places, but inconsistently.
For example some unit tests now expect N5IOException to be thrown. However many methods throw IOException instead.

For example, throwing N5IOException here

public AmazonS3KeyValueAccess(final AmazonS3 s3, final String bucketName, final boolean createBucket) throws N5Exception.N5IOException {
to make unit tests happy feels wrong, when all other methods there throw normal IOException as per KeyValueAccess interface declaration.

What is the idea with N5Exception.N5IOException? Why does it exist? Is it intended to replace all usage of IOException? Or when should the one or the other be chosen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant