fix(ci): backport #926 — move matrix.name guard to step-level if - #927
Merged
Conversation
) job-level \if\ conditions do not have access to the \matrix\ context in GitHub Actions — using \matrix.name\ there causes a workflow parse failure and the entire workflow silently fails with zero jobs. Fix by: - Removing the job-level \if\ condition that referenced \matrix.name\ - Moving the path-filter guard to a step-level \if\ on the build step, where \matrix\ context is valid - Making the \changes\ job always run (condition moved to its steps) so that \�uild\, which needs it, is never skipped due to a skipped dep - Using \github.event_name != 'push' || ref == main || changes.output\ logic instead of the equivalent but invalid job-level expression This unblocks GHCR image publishing for all triggers. Co-authored-by: Cypher <223556219+Copilot@users.noreply.github.com> Copilot-Session: 11857092-1327-41bd-8708-b2ca85e674dd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #926 to \dev.
Fixes \publish-images.yml\ workflow parse failure caused by \matrix.name\ in a job-level \if\ condition (not allowed by GitHub Actions). GHCR image publishing was silently broken for all events.