Skip to content

feat: add two-App persistence foundation - #954

Merged
sabbour merged 1 commit into
devfrom
tank/940-two-app-persistence
Aug 27, 2026
Merged

feat: add two-App persistence foundation#954
sabbour merged 1 commit into
devfrom
tank/940-two-app-persistence

Conversation

@sabbour

@sabbour sabbour commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add two-App durable records, guarded persistence store, SQLite/PostgreSQL migrations and snapshots.
  • Enforce project cascade, one-active Copilot binding, authorization claim and invocation uniqueness; use opaque credential references and immutable versions/digests only.
  • Remove Key Vault post-write disk mirroring and make SQLite-to-PostgreSQL transfer transactional for the two-App record set.

Verification

  • npm run validate:layer -- --area dotnet --dotnet-filter "FullyQualifiedName~TwoAppPersistenceStoreTests|FullyQualifiedName~TwoAppPersistencePostgresTests|FullyQualifiedName~DataMigratorTests|FullyQualifiedName~KeyVaultGitHubTokenStoreTests" (43 passed; 5 Postgres/Testcontainers tests skipped because Docker is unavailable)
  • SQLite and PostgreSQL dotnet ef migrations has-pending-model-changes report no changes.

Closes #940

Closes #940

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 7762866f-fa88-4087-b5df-17f482d36ec0
@sabbour
sabbour force-pushed the tank/940-two-app-persistence branch from 4e522ea to 68ede03 Compare August 27, 2026 11:57
@sabbour

sabbour commented Aug 27, 2026

Copy link
Copy Markdown
Owner Author

Post-implementation review complete: code review initially identified SQLite source-schema compatibility, provider-FK parity, SQLite uniqueness classification, and PostgreSQL audit identity sequencing; all were fixed in 68ede03e and re-review reported no significant issues. Seraph security review and re-review reported no security findings. Focused layer validation passes (43 passed; 5 Postgres/Testcontainers tests skipped because Docker is unavailable).

@sabbour
sabbour merged commit 217577d into dev Aug 27, 2026
13 checks passed
@sabbour
sabbour deleted the tank/940-two-app-persistence branch August 27, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: persist two-App identity and activation records

2 participants