feat: add refreshFrequency option for blocking strategy #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @nickalie thanks for that pull request! |
acouvreur
force-pushed
the
feature/blocking-refresh-frequency-config
branch
from
d07074f to
30ea44a
Compare
|
Some issues Probably from parsing or default value ? |
Signed-off-by: Alexis Couvreur <[email protected]>
Signed-off-by: Alexis Couvreur <[email protected]>
add missing value to config.yml for blocking refresh frequency tests update SessionsManagerMock RequestReadySession method to accept frequency
nickalie
force-pushed
the
feature/blocking-refresh-frequency-config
branch
from
9756f0e to
c93c799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for initial start blocking strategy always takes at least 5 seconds, before bypassing the request to the target container. Though the container itself may start in half a second, blocking strategy still waits for 5 seconds due to hard-coded refresh frequency.
The PR adds customizable
refreshFrequencyoption to the blocking requests. Works in similar way asrefreshFrequencyoption for the dynamic strategy. For instance, if you setrefreshFrequencyto 100ms and your container starts in 500ms, the end user will receive response for the very first request in about 600-700ms instead of 5000ms for blocking strategy