Skip to content

Conversation

phil-davis
Copy link
Contributor

Let's see if GitHub knows about PHP 8.4 alpha yet.

@phil-davis phil-davis self-assigned this Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (9d02602) to head (fd602f9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #124   +/-   ##
=========================================
  Coverage     99.18%   99.18%           
  Complexity      111      111           
=========================================
  Files             7        7           
  Lines           370      370           
=========================================
  Hits            367      367           
  Misses            3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@staabm
Copy link
Member

staabm commented Jul 24, 2024

I would be fine with skipping cs-fixer for 8.4 for now

@staabm
Copy link
Member

staabm commented Jul 24, 2024

(or maybe we just need to update cs-fixer)

@phil-davis
Copy link
Contributor Author

I would be fine with skipping cs-fixer for 8.4 for now

I just want to see if it reports anything interesting (it shouldn't!), and it passed like this.

Now to look at the phpstan deprecation messages.

@phil-davis
Copy link
Contributor Author

The deprecation messages are all for vendor packages. And some are inside vendor, phpstan, vendor again - dependencies of phpstan itself.

So various dependencies need to be "fixed" first anyway.

@phil-davis phil-davis mentioned this pull request Jul 24, 2024
@phil-davis
Copy link
Contributor Author

See PR #126 for the 5.1 branch. We can get that approved and merged first, then I will see what finally should be done here in master.

@phil-davis
Copy link
Contributor Author

See #136

@phil-davis phil-davis closed this Sep 6, 2024
@phil-davis phil-davis deleted the php-8.4-ci branch September 6, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants