Skip to content

Exercise 1 python. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Exercise 1 python. #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3972ed8
add y to vowels
hkershaw-brown Dec 15, 2023
090a4c3
return count of consontants rather than printing the consonant.
hkershaw-brown Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions python/exercise1/vowel_counter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,19 @@

def num_vowels(text):
"""Return the number of vowels in string."""
vowels = "aeiou"
vowels = "aeiouy"
Copy link
Copy Markdown
Owner

@sabrinacamp2 sabrinacamp2 Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend defining the vowels outside of the num_vowels() and num_consonants() functions since you are defining this twice (DRY principle). Also, I'm curious, is "y" considered a vowel?

num = 0
for v in vowels:
num += text.lower().count(v)
return num

def num_consonants(text):
vowels = "aeiou"
vowels = "aeiouy"
num = 0
for letter in text:
if letter not in vowels:
print("consonant", letter)
Copy link
Copy Markdown
Owner

@sabrinacamp2 sabrinacamp2 Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be mistaken, but do you still want something printed out when the function is called?

num += text.lower().count(letter)
return num

text = str(input("Enter a sentence: "))

Expand Down