Open
Conversation
fix measurements for salt - should be teaspoon convert 240g of flour to cups to use the same units as the other solid ingredients
sabrinacamp2
requested changes
Jul 17, 2024
Owner
sabrinacamp2
left a comment
sabrinacamp2
left a comment
There was a problem hiding this comment.
Overall, I think the suggested changes greatly improve the clarity of the yellow cake recipe. I would recommend adding the numbered steps to the directions. Otherwise, everything looks great! Nice work.
| ## Recipe for Yellow Cake | ||
|
|
||
| Yellow cake is delicious! This recipie is passed down from my great-great-grandparents. | ||
| Yellow cake is delicious! This recipe is passed down from my great-great-grandparents. |
Owner
There was a problem hiding this comment.
Nice catch on this spelling mistake and others.
Comment on lines
+20
to
30
| ### Directions | ||
|
|
||
| Preheat the oven to 350 degrees F (175 degrees C). | ||
|
|
||
| Grease a 9x13-inch baking pan. | ||
|
|
||
| Mix the flour, baking powder, and salt together in a medium bowl. | ||
|
|
||
| Beat sugar and shortening together in a large bowl with an electric mixer until light and fluffy. | ||
|
|
||
| Add eggs, one at a time, beating thoroughly after each adding each egg. |
Owner
There was a problem hiding this comment.
You mentioned in the PR summary that you added numbered steps to the recipe, but I don't see that reflected here. Maybe consider adding numbered steps to your already well outlined and spaced directions.
| @@ -1,25 +1,30 @@ | |||
| ## Recipice for Chocolate Cake | |||
| ## Recipe for Yellow Cake | |||
Owner
There was a problem hiding this comment.
Nice use of markdown headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the cake recipe to
reduce the amount of salt, and describe the
cake correctly as yellow cake rather than
chocolate cake.
I've added numbered steps to the recipe.
Also there are several spelling errors that I
have corrected.
Fixes issue
Fixes #2 text