Hidden slides shouldn't affect slider width#94
Open
norin89 wants to merge 2 commits into
Open
Conversation
* due to wrong slider scaling if it's invisible initially
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I really appreciate your work. I'm using your plugin in my latest project but I found some issue during development. I've created a filter that shows and hides certain slides so I can show only some of them. But if I set
display: none;to any of slide it's width still affects whole slider width. There can be other reasons someone wants to keep hidden slides so I've made subtle changes to forcelightsliderto work only with visible slides. Please take a look :)P.S. I did quick test to check if it still works well in
slidemode and it seems it does!Regards,
Marcin