Add a wrapper contract that allows users to use ETH instead of WETH #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
=========================================
Coverage ? 99.42%
=========================================
Files ? 15
Lines ? 1036
Branches ? 154
=========================================
Hits ? 1030
Misses ? 6
Partials ? 0
Continue to review full report at Codecov.
|
0xKiwi
reviewed
Jun 17, 2021
| } else { | ||
| IWETH9(weth).withdraw(amounts[i]); | ||
| // slither-disable-next-line arbitrary-send | ||
| (bool success, ) = msg.sender.call{value: amounts[i]}(""); |
There was a problem hiding this comment.
Why performing the send like this instead of a normal transfer?
There was a problem hiding this comment.
Not sure if this is a legit concern as of today but in case the gas requirements for certain smart contract interactions change, .transfer could fail.
https://consensys.net/diligence/blog/2019/09/stop-using-soliditys-transfer-now/
0xKiwi
reviewed
Jun 17, 2021
penandlim
force-pushed
the
john/ethWrapper
branch
from
b2aa4e9
to
93cbecc
Compare
sandrasong
approved these changes
Jun 30, 2021
alphastorm
force-pushed
the
master
branch
6 times, most recently
from
5ac5eb5
to
9291414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwapEthWrapper.solis a wrapper contract ofSwap.solvariants. It allows users to use ETH instead of WETH whenever interacting with this contract.The params associated with the WETH9 token in the underlying pool should match the
msg.value. For more details please take a look at the test cases foraddLiquidity()orswap()functions