fix: replace hardcoded background color with design token #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace bg-[#09090b] with bg-background in checkout pages. The hardcoded color is identical to the --background CSS variable (both are HSL 240 10% 3.9%), so this change has zero visual impact while improving maintainability. Found with Buoy — design system drift detection
|
@dylantarre is attempting to deploy a commit to the sadmann7 Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
bg-[#09090b]withbg-backgroundin checkout pages (2 instances)Why
The hardcoded hex
#09090bis identical to your--backgroundCSS variable in dark mode:#09090b= HSL(240, 10%, 3.9%)--background(dark) =240 10% 3.9%This change has zero visual impact while improving maintainability.
Files Changed
src/app/(checkout)/checkout/[storeId]/loading.tsxsrc/app/(checkout)/checkout/[storeId]/page.tsxTest plan
Found with Buoy — design system drift detection