Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure and run pre-commit #699

Merged
merged 16 commits into from
Nov 14, 2024
Merged

Configure and run pre-commit #699

merged 16 commits into from
Nov 14, 2024

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Nov 4, 2022 •
edited
Loading

@Uxio0 Uxio0 requested a review from a team as a code owner November 4, 2022 11:15
fmrsabino
fmrsabino suggested changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@fmrsabino fmrsabino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is doing many changes and I believe more context is needed

.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
requirements-dev.txt Outdated Show resolved Hide resolved
@Uxio0 Uxio0 force-pushed the configure-pre-commit branch from 9acf10f to aae83c7 Compare November 4, 2022 16:07
@Uxio0 Uxio0 force-pushed the configure-pre-commit branch from aae83c7 to b27490e Compare November 4, 2022 16:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3395314213

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.772%
Totals Coverage Status
Change from base Build 3395265201: 0.0%
Covered Lines: 876
Relevant Lines: 878
💛 - Coveralls

@Uxio0
Copy link
Member Author

Uxio0 commented May 30, 2024

@hectorgomezv do you think this is relevant nowadays or should I close it? I still feel that all the Safe projects should have the same linting/style

@hectorgomezv hectorgomezv requested a review from a team as a code owner August 23, 2024 11:23
@coveralls
Copy link

coveralls commented Aug 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11837185862

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.503%
Totals Coverage Status
Change from base Build 11837107157: 0.0%
Covered Lines: 1202
Relevant Lines: 1208
💛 - Coveralls

@hectorgomezv
Copy link
Member

@hectorgomezv do you think this is relevant nowadays or should I close it? I still feel that all the Safe projects should have the same linting/style

Sorry @Uxio0, I completely missed this comment. I've fixed some conflicts on the PR. If you are OK with the changes I think we can merge.

@hectorgomezv hectorgomezv requested review from fmrsabino and removed request for fmrsabino October 16, 2024 11:34
@hectorgomezv
Copy link
Member

@Uxio0 we did some amendments (branch rebasing mostly) to the PR, if you are OK with the current status we will merge it finally 🙂

Uxio0
Uxio0 commented Oct 16, 2024
View reviewed changes
.github/workflows/test.yml Outdated
run: flake8
strategy:
matrix:
python-version: ["3.12.2"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave this as 3.12 so hotfixes are auto updated

Uxio0
Uxio0 commented Oct 16, 2024
View reviewed changes
Copy link
Member Author

@Uxio0 Uxio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, but everything else looks good!

@hectorgomezv
Copy link
Member

Just a minor comment, but everything else looks good!

Thanks! Done in 2b6a52b

@hectorgomezv hectorgomezv merged commit b994143 into main Nov 14, 2024
13 checks passed
@hectorgomezv hectorgomezv deleted the configure-pre-commit branch November 14, 2024 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fmrsabino fmrsabino fmrsabino requested changes

@hectorgomezv hectorgomezv hectorgomezv approved these changes

@moisses89 moisses89 Awaiting requested review from moisses89 moisses89 was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Uxio0 @coveralls @hectorgomezv @fmrsabino