feat: 🎸 Add See More Section #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
reviewed
Jul 31, 2024
Comment on lines
32
to
43
| useEffect(() => { | ||
| if (!containerRef.current) return | ||
|
|
||
| const updateWidth = (entries: ResizeObserverEntry[]) => { | ||
| setWidth(entries[0].contentRect.width) | ||
| } | ||
|
|
||
| const resizeObserver = new ResizeObserver(updateWidth) | ||
| resizeObserver.observe(containerRef.current) | ||
|
|
||
| return () => resizeObserver.disconnect() | ||
| }, []) |
There was a problem hiding this comment.
Nit: let's move this to a custom hook. We could make it reusable and return the width and height.
|
|
||
| pathRef.current?.setAttribute('d', `M${path}`) | ||
|
|
||
| requestRef.current = requestAnimationFrame(animate) |
There was a problem hiding this comment.
We don't need to use a ref for this. We can use a local variable.
DiogoSoaress
reviewed
Aug 5, 2024
DiogoSoaress
approved these changes
Aug 12, 2024
|
|
||
| const pathElement = containerRef.current?.querySelector('path') | ||
| if (pathElement) { | ||
| pathElement.setAttribute('d', `M${path}`) |
There was a problem hiding this comment.
I am having a runtime error coming from this line
DiogoSoaress
requested changes
Aug 15, 2024
|
I have moved the implementation of the Wave Animation to PR #441 as it is not yet performant. |
DiogoSoaress
requested changes
Aug 20, 2024
Comment on lines
30
to
32
| { | ||
| //Moved the wave animation to PR #441 | ||
| } |
There was a problem hiding this comment.
Suggested change
| { | |
| //Moved the wave animation to PR #441 | |
| } |
There was a problem hiding this comment.
Was previously addressed in 44b8b93
DiogoSoaress
approved these changes
Aug 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #384