-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Safe Apps): Add option for Safe Apps to include Telegram ID as a social media link #4762
base: dev
Are you sure you want to change the base?
Conversation
ef8696c
to
5955296
Compare
Branch preview✅ Deploy successful! Storybook: |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟡 | Statements | 74.28% (+0.01% 🔼) |
14765/19877 |
🔴 | Branches | 52.05% (+0.02% 🔼) |
3536/6794 |
🔴 | Functions | 57.38% | 2096/3653 |
🟡 | Lines | 75.82% (+0.01% 🔼) |
13398/17670 |
Test suite run success
1793 tests passing in 242 suites.
Report generated by 🧪jest coverage report action from 7922961
5955296
to
b2623b1
Compare
📦 Next.js Bundle Analysis for @safe-global/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
1.04 MB (🟡 +54.11 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Thirty-one Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/ |
508 B (🟢 -2 B) |
1.04 MB |
/address-book |
23.21 KB (🟡 +142 B) |
1.06 MB |
/apps |
35.97 KB (🟡 +2.24 KB) |
1.08 MB |
/apps/custom |
34.03 KB (🟡 +2.25 KB) |
1.07 MB |
/apps/open |
55.57 KB (🟡 +1.96 KB) |
1.1 MB |
/balances |
29.88 KB (🟡 +176 B) |
1.07 MB |
/balances/nfts |
9.52 KB (🟢 -24 B) |
1.05 MB |
/bridge |
2.56 KB (🟡 +2 B) |
1.04 MB |
/cookie |
8.77 KB (🟡 +1 B) |
1.05 MB |
/home |
61.54 KB (🟡 +2.28 KB) |
1.1 MB |
/new-safe/advanced-create |
26.38 KB (🟢 -70 B) |
1.07 MB |
/new-safe/create |
25.52 KB (🟢 -71 B) |
1.07 MB |
/privacy |
14.57 KB (🟡 +2 B) |
1.06 MB |
/settings/appearance |
2.25 KB (🟡 +2 B) |
1.04 MB |
/settings/environment-variables |
3.27 KB (🟢 -1 B) |
1.04 MB |
/settings/modules |
4.06 KB (🟡 +1 B) |
1.05 MB |
/settings/notifications |
6.33 KB (🟢 -14.99 KB) |
1.05 MB |
/settings/safe-apps |
20.35 KB (🟡 +2.08 KB) |
1.06 MB |
/settings/security |
2.34 KB (🟡 +1 B) |
1.04 MB |
/settings/setup |
30.83 KB (🟡 +94 B) |
1.07 MB |
/share/safe-app |
7.56 KB (🟢 -5 B) |
1.05 MB |
/stake |
618 B (🟢 -1 B) |
1.04 MB |
/swap |
761 B (🟡 +1 B) |
1.04 MB |
/terms |
12.93 KB (🟡 +1 B) |
1.05 MB |
/transactions |
99.46 KB (🟡 +2.89 KB) |
1.14 MB |
/transactions/history |
99.42 KB (🟡 +2.89 KB) |
1.14 MB |
/transactions/messages |
60.25 KB (🟡 +1.95 KB) |
1.1 MB |
/transactions/msg |
56.5 KB (🟡 +1.95 KB) |
1.1 MB |
/transactions/queue |
49.36 KB (🟡 +1.96 KB) |
1.09 MB |
/transactions/tx |
48.72 KB (🟡 +1.96 KB) |
1.09 MB |
/welcome/accounts |
409 B (🟡 +2 B) |
1.04 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
component="a" | ||
href={telegramSocialLink.url} | ||
target="_blank" | ||
style={{ height: '40px', width: '40px' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add rel="noopener noreferrer"
to this and the other IcoButtons in this file?
Might be good to create a component to not repeat the same 6 lines for each button.
function IconButtonLink({ href, label, children }) {
return (
<IconButton
aria-label={label}
component="a"
href={href}
target="_blank"
rel="noopener noreferrer"
style={{ height: '40px', width: '40px' }}>
{children}
</IconButton>
)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katspaugh I added the rel
attribute.
7922961
I suggest postponing the creation of a new component to a separate PR.
b2623b1
to
7922961
Compare
What it solves
Resolves the lack of support for Telegram as a social media option for Safe Apps.
How this PR fixes it
This PR adds an option for Safe Apps to include their Telegram ID in the social media section.
How to test it
Screenshot
Checklist