Support for Calico and secret generation during runtime with validation for required fields. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the calico networking chart as a dependency for the secure-enclave chart, enabling network policy functionality. It includes the necessary Chart.yaml, Chart.lock, and values files for calico, along with updates to secure-enclave to reference the new calico dependency. The secure-enclave chart now conditionally installs calico based on the networkPolicy.enabled flag, and includes new network policy templates for trusted output applications. Additionally, the secure-enclave chart now uses a dedicated enclave-secret instead of individual secrets for setup and management apps.
…t.yaml Renamed the deployment template file to better reflect its purpose as an application deployment configuration, improving clarity and consistency in the secure enclave templates directory.
- Added file readability check before processing docker auth file - Updated JSON field names from .username/.password to .name/.secret - Implemented validation for required fields (username, password, serveraddress) - Added error handling for missing or empty environment variables - Maintained backward compatibility with existing workflow The changes improve the robustness of the harbor-login script by adding proper input validation and error handling for the docker authentication file format.
…d" to "name"/"secret" in README.md. Also restructured the AWS storage class configuration documentation to provide more detailed descriptions for each parameter, improving clarity and usability for users deploying on AWS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
This commit introduces the calico networking chart as a dependency for the secure-enclave chart, enabling network policy functionality. It includes the necessary Chart.yaml, Chart.lock, and values files for calico, along with updates to secure-enclave to reference the new calico dependency. The secure-enclave chart now conditionally installs calico based on the networkPolicy.enabled flag, and includes new network policy templates for trusted output applications. Additionally, the secure-enclave chart now uses a dedicated enclave-secret instead of individual secrets for setup and management apps.
Currently we bundle calico as a sub/chart but could also update the
secure-enclave/Chart.yamlto point to the calico repository instead.Limitations:
Todo: