Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to MacOs / Add drop support in the main menu #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MarkusJx
Copy link

  • Bump the version of 'electron-builder' to 21.2.0, since this is the minimum required version for MacOs (Catalina)
  • Instead of command-line arguments, use app.on('open-file', (event, path) => {...} to get files to be opened at program start. General idea described here.
  • Set titleBarStyle: 'hidden', to hide the original title bar, but to keep the 'close', 'minimize' and 'maximize' options in the custom title bar
  • Use ipc to tell the main process, when the web page has finished loading to keep the the 'Open With' option working when the program is already running
  • Add 'mac' build option

Bumped the electron-builder version to 21.2.0; Added mac build option; Fixed title bar; Fixed 'open with...' for mac os
@MarkusJx MarkusJx changed the title Port to MacOs Port to MacOs / Add drop support in the main menu Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant