Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random test failures in finitely_presented_named #38889

Open
2 tasks done
tobiasdiez opened this issue Oct 30, 2024 · 3 comments · May be fixed by #38956
Open
2 tasks done

Random test failures in finitely_presented_named #38889

tobiasdiez opened this issue Oct 30, 2024 · 3 comments · May be fixed by #38956
Labels
t: bug

Comments

@tobiasdiez
Copy link
Contributor

Steps To Reproduce

No response

Expected Behavior

Test pass

Actual Behavior

sage -t --warn-long 5.0 --random-seed=130677747974987316498399576088509580425 src/sage/groups/finitely_presented_named.py
**********************************************************************
File "src/sage/groups/finitely_presented_named.py", line 485, in sage.groups.finitely_presented_named.AlternatingPresentation
Failed example:
    A1.is_isomorphic(A2), A1.order()
Expected:
    (True, 1)
Got:
    #I  Forcing finiteness test
    (True, 1)

Additional Information

No response

Environment

Linux: https://github.com/sagemath/sage/actions/runs/11572245422/job/32211815924

Checklist

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.
  • I have read the documentation and troubleshoot guide
@miguelmarco
Copy link
Contributor

Does it happen consistently or is it random?

@tobiasdiez
Copy link
Contributor Author

Random but pretty often. I only looked at the meson workflow so far, not sure if it is specific to this.

@user202729
Copy link
Contributor

Looks like that specific comment comes from GAP.

A previous commit that modifies these things is 36b305f .

If it's random it may be difficult…

@user202729 user202729 mentioned this issue Nov 8, 2024
Open
5 tasks
orlitzky added a commit to orlitzky/sage that referenced this issue Nov 12, 2024
@orlitzky
src/sage/groups/libgap_mixin.py: hide info warning for isomorphism ch…
704ed9f 
…ecks

GAP emits an "InfoWarning" message when it is checking for isomorphism
between two groups that are not known to be finite. This message is
only shown once, however, because after it checks for finiteness, it
knows. We have to keep this in mind during tests. For example,

  File "src/sage/groups/finitely_presented_named.py", line 485, in
  sage.groups.finitely_presented_named.AlternatingPresentation
  Failed example:
      A1.is_isomorphic(A2), A1.order()
  Expected:
      (True, 1)
  Got:
      #I  Forcing finiteness test
      (True, 1)

These warnings are "normal" and there's nothing for the user to do.
This commit hides them for the duration of the isomorphism check.

Fixes sagemath#38889
orlitzky added a commit to orlitzky/sage that referenced this issue Nov 12, 2024
@orlitzky
src/sage/**/*.py: remove GAP warnings from expected output
060f115 
The warning "#I  Forcing finiteness test" should no longer be emitted
when checking for group isomorphism, so we remove it from the expected
output in a few places.

Fixes sagemath#38889
@orlitzky orlitzky linked a pull request Nov 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide GAP finiteness warnings during isomorphism check orlitzky/sage
3 participants
@miguelmarco @tobiasdiez @user202729