Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some last traces of Trac #37385

Merged
merged 4 commits into from
Feb 25, 2024
Merged

Remove some last traces of Trac #37385

merged 4 commits into from
Feb 25, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 18, 2024

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@GiacomoPope
Copy link
Contributor

Is it worth replacing :trac: for :issue: in the doctests? Apologies if this has already been done.

@mkoeppe mkoeppe changed the title Remove last traces of Trac Remove some last traces of Trac Feb 18, 2024
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 18, 2024

Is it worth replacing :trac: for :issue: in the doctests?

Not in this PR, but sure, why not

@GiacomoPope GiacomoPope mentioned this pull request Feb 18, 2024
Merged
@kwankyu
Copy link
Collaborator

kwankyu commented Feb 19, 2024

Otherwise lgtm.

kwankyu
kwankyu approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 19, 2024

Thanks!

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 8d3a589; changes) is ready! 🎉

@vbraun vbraun merged commit ccd3f8b into sagemath:develop Feb 25, 2024
25 of 40 checks passed
vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 6, 2024
sagemathgh-37390: Replace all :trac: with :issue: in docstrings
31d9bb6 
Following the PR sagemath#37385, I have
replaced all occurrences of `:trac:` with `:issue:`.

If changing so much in one PR is wrong and this should be done file by
file while working on other functions feel free to close this PR.

URL: sagemath#37390
Reported by: Giacomo Pope
Reviewer(s): Giacomo Pope, Kwankyu Lee
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees
No one assigned
Labels
c: documentation c: scripts
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
4 participants
@mkoeppe @GiacomoPope @kwankyu @vbraun