workspace: fix arg parsing for args with whitespace #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLI args with whitespace were not being perserved when creating the workspace task script, so that a single arg was being split into multiple args for the workspace member's task run. For example `--feature "f1 f2"` was being seen as `--feature f1 f2` The result was an error because the `f2` was not seen as associated with the `--feature` flag anymore.
Author
|
Should I file a bug for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI args with whitespace were not being perserved when creating the workspace task script, so that a single arg was being split into multiple args for the workspace member's task run.
For example
--feature "f1 f2"was being seen as
--feature f1 f2The result was an error because the
f2was not seen as associated with the--featureflag anymore.