refactor: URL-as-view-state architecture + data-layer fixed - #13
Open
gersondiaz12 wants to merge 4 commits into
Open
refactor: URL-as-view-state architecture + data-layer fixed#13gersondiaz12 wants to merge 4 commits into
gersondiaz12 wants to merge 4 commits into
Conversation
Every screen is a URL. 15 modals become routes under a data router. Fixed calendar and re-designed the graph on the friends section
sah-rohan
requested changes
Sep 2, 2026
sah-rohan
left a comment
sah-rohan
left a comment
Owner
There was a problem hiding this comment.
- Only have ui code changes no review.md or any of that
- Also you did not make this for dark mode
sah-rohan
requested changes
Sep 2, 2026
sah-rohan
left a comment
sah-rohan
left a comment
Owner
There was a problem hiding this comment.
Also obviously you need to change the actual readme with the new screenshots as well
sah-rohan
requested changes
Sep 2, 2026
sah-rohan
left a comment
sah-rohan
left a comment
Owner
There was a problem hiding this comment.
Please remove the comments, they provide obvious code evaluations and make the code the hard to read in general
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every screen is a URL. 15 modals become routes under a data router.
Fixed calendar and re-designed the graph on the friends section.