-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #269
Open
The-Unsticker
wants to merge
1
commit into
sailfishos:master
Choose a base branch
from
The-Unsticker:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update README.md #269
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and welcome! Unfortunately there is a little of misunderstanding.
The most important nonfunctional feature of the SDK is that it does not lock the user into a virtual machine in order to enable cross platform development. Just parts of the SDK run in a VM and those parts are not those parts a regular user usually interacts with. From SDK user's point of view Sailfish SDK is a fully native development environment.
The suggested formulation suggests the exact opposite: that the user would be using the SDK from within a VM.
Beside that, installing one of the supported virtualization platforms is just one of the prerequisites that need an attention from the user prior to installation, so the notice should be more generic.
Also, better place for the notice would be the home page of the SDK https://docs.sailfishos.org/Tools/Sailfish_SDK/ which actually already contains such a notice - it is the second sentence, so already now it is quite hard to miss. It could be shortened and highlighted a bit more though, like
The sentence would be also better moved above the links to installers, so that it is read first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your reply and I accept your concern about implying eg the IDE runs in a VM.
The Tools page is fine at a glance. The Installation page likewise.
The problem as I see it is with the Apps page.
It says:
"Getting started with the SDK is a fairly simple process:
Install
Download the latest SDK installers and install it. Read more about [SDK Installation]
It implies that running the installer is all it takes.
Installing the SDK is not a simple process. It is the most complicated installation I've done in 30 years, including unlocking my phone and installing Sailfish.
This declared simplicity further inclines people to ignore the "Read more about" line.
So both the declared simplicity and the "Read more about" line ought to be changed.
Important high-level & introductory information for the top of this page would be:
Only #4 is addressed and much lower in the page and implies it's for help with coding.