Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to APKPure, because it distributes some malware #404

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Olf0
Copy link
Contributor

@Olf0 Olf0 commented Apr 12, 2024

Partially fixes issue #401, i.e. its whole point 2, but not point 1; for detailed reasoning, see there.

@Olf0 Olf0 marked this pull request as ready for review April 12, 2024 23:58
…ne_part2/README.md] Link to AppSupport page instead of duplicating statements
Copy link
Contributor

@jovirkku jovirkku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence (although modified) on line 44 must remain - it is becoming more valid on 4.6.0:

Note that "Settings > System > Untrusted software" must be enabled to install Android apps, too.

UPDATE:
Or perhaps not as it is well stated at the beginning of Help_Articles/Android_App_Support/README.md

@Olf0
Copy link
Contributor Author

Olf0 commented Apr 22, 2024

UPDATE: Or perhaps not as it is well stated at the beginning of Help_Articles/Android_App_Support/README.md

Exactly!
There was some duplicated information in these articles and I tried to deduplicate it, because duplicated information is hard to maintain in parallel and hence tends to become out-of-sync, which confuses users.

You already pointed to the central article for AAS: /Support/Help_Articles/Android_App_Support/README.md
Details with regard to AAS should be aggregated there. Furthermore this article directly links to it, see https://github.com/sailfishos/docs.sailfishos.org/pull/404/files#diff-cb55aa306d42f320ed6e0b909ae08330e7927817f84062aadd128a79700b391bR44. Consequently re-duplicating this information is counterproductive.


Side note / question:

This sentence (although modified) on line 44 must remain - it is becoming more valid on 4.6.0:

Note that "Settings > System > Untrusted software" must be enabled to install Android apps, too.

I wonder what "more valid" is supposed to mean:

  1. Does the installation of an APK from the file system via the Settings app's file browser respectively the native apps File Browser and FileCase (e.g. for the initial installation of a downloaded APK of an Android app store client by GUI means) require "Allow untrusted software" to be switched on, starting with SailfishOS 4.6.0?
  2. Or does the installation of an APK by the help of an Android app store client app require "Allow untrusted software" to be switched on, starting with SailfishOS 4.6.0? (This would be bad and disruptive!)

IIRC "Allow untrusted software" only affected SailfishOS-native apps on SailfishOS < 4.6.0, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants