Fix implicit declaration of statx gate helper function and includes #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i_virtualize_struct_statx was only implicitly defined in
vterm_statfuns.c as config.h which defines HAVE_STATX wasn't included.
Consistently include config.h before any other header to avoid issues
like these:
preload/vperm_filestatgates.c: In function ‘statx_gate’:
preload/vperm_filestatgates.c:272:17: error: implicit declaration of function ‘i_virtualize_struct_statx’; did you mean ‘i_virtualize_struct_stat’? [-Wimplicit-function-declaration]
272 | i_virtualize_struct_statx(realfnname, buf);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| i_virtualize_struct_stat
Also use consistent include order and naming in all files.
Fixes: 0ecaef5 ([sb2] Add gate for statx. JB#49501)
Signed-off-by: Björn Bidar <[email protected]>
[sb2] Fix implicit declaration of function ‘i_virtualize_struct_statx’. Fixes JB#62739
include/elf.h:25:14: error: expected ‘;’ before ‘typedef’
25 | __BEGIN_DECLS
| ^
| ;
Fixes: 055cb96 (Incomplete OS X support)
Signed-off-by: Björn Bidar <[email protected]>
Fixes errors such as: include/rule_tree.h:22:9: error: unknown type name ‘uint32_t’ 22 | typedef uint32_t ruletree_object_offset_t; Signed-off-by: Björn Bidar <[email protected]>
preload/vperm_statfuncts.c:122:5: warning: no previous prototype for ‘i_virtualize_struct_stat_internal’ [-Wmissing-prototypes] 122 | int i_virtualize_struct_stat_internal( Fixes: 0ecaef5 ([sb2] Add gate for statx. JB#49501) Signed-off-by: Björn Bidar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix implicit declaration of statx gate helper function and includes
vterm_statfuns.c as config.h which defines HAVE_STATX wasn't included.
Consistently include config.h before any other header to avoid issues
Fix expected ‘;’ before ‘typedef’
sys/cdefswasn't included in the vendored copy of elf-utils elf.hInclude missing type headers