Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

360 photo and video support #367

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

360 photo and video support #367

wants to merge 3 commits into from

Conversation

mittman
Copy link

@mittman mittman commented Mar 9, 2019

Basic integration of Valiant360 webGL library to view 360-degree photos and videos within sigal gallery. Modification of galleria theme, click VR icon or on the active image to open modal.

@codecov
Copy link

codecov bot commented Mar 9, 2019

Codecov Report

Merging #367 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files          18       18           
  Lines        1443     1443           
=======================================
  Hits         1261     1261           
  Misses        182      182

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 912ca39...4f2abc0. Read the comment docs.

@saimn
Copy link
Owner

saimn commented Mar 13, 2019

Hi,
Thanks for the PR, this seems to be a nice feature. However I'm not sure to want this in the core galleria theme, because this means more dependencies, and for each release it is a lot of work to update all the dependencies to their latest versions and check that everything still works.
What would think about putting this in another repository, like the 153957-theme (which can be pip-installed, which is great but not strictly necessary) ? The theme could then be referenced in https://github.com/saimn/sigal/wiki with other community efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants