SAK-50970 When you impersonate a instructor and use Enter Student View, when you exit, you should return to the instructor sessions instead of admin session

[susowrc]

SAK-50970 When you impersonate a instructor and use Enter Student View, when you exit, you should return to the instructor sessions instead of admin session

https://sakaiproject.atlassian.net/browse/SAK-50970

[susowrc]

Please @ern and @jesusmmp could you review the changes uploaded?

[ottenhoff]

Awesome. I just noticed this yesterday.

[ern]

please address the thread safety issue

[ern]

an interesting question would be why it returns to the admin user?

[ern]

so I understand why it goes back to the admin user:

• the issue here is that the restoreUser, is restoring the user using the original UsageSession which is the admin user
• so when your impesonating 2x
• once with BecomeUser and then once with Enter Student View
• the original UsageSession is always the original (admin) user (edited)
• before the first impersonation

[susowrc]

I apply changes as mentioned. @ern, can you please review it?. Thank you.