-
-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAK-49359 Portal add sub-sites dropdown #13288
base: master
Are you sure you want to change the base?
Conversation
|
||
import org.sakaiproject.portal.api.PortalSubPageNavProvider; | ||
|
||
public class PortalSubPageNavProviderImpl implements PortalSubPageNavProvider { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this probably wasn't needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct..... it doesn't have enough info to be able to implement this .... you need to know the parents and children of all sites the user has access to
portal/portal-impl/impl/src/java/org/sakaiproject/portal/charon/site/PortalSiteHelperImpl.java
Outdated
Show resolved
Hide resolved
…n/site/PortalSiteHelperImpl.java Co-authored-by: Adrian Fish <[email protected]>
Could we have some screenshots under the new skin when this is ready? Thanks! |
![]() @bgarciaentornos note that I'm not recommending this as a new feature. It's really just restoring functionality from Sakai 22. I think this is a classic 1% type of feature where it is used by only one program in one school. I think the right thing to do is restore the broken functionality and then hide the functionality via a Sakai property. Unless you have a direct use case for this functionality, I don't recommend it as a new feature. |
I agree it's not widely used and not recommended or needed nowadays. Anyway, I think it's good to keep support for it, just wanted to see how it looked, thanks! |
NP. do you know of anyone using it or looking for it? What do you think about disabling by default? |
Not sure tbh, but I'm fine about disabling it by default |
No description provided.