Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-49359 Portal add sub-sites dropdown #13288

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ottenhoff
Copy link
Contributor

No description provided.

@ottenhoff ottenhoff marked this pull request as draft February 7, 2025 16:28

import org.sakaiproject.portal.api.PortalSubPageNavProvider;

public class PortalSubPageNavProviderImpl implements PortalSubPageNavProvider {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably wasn't needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct..... it doesn't have enough info to be able to implement this .... you need to know the parents and children of all sites the user has access to

@bgarciaentornos
Copy link
Contributor

Could we have some screenshots under the new skin when this is ready? Thanks!

@ottenhoff ottenhoff marked this pull request as ready for review February 12, 2025 16:45
@ottenhoff
Copy link
Contributor Author

Screenshot 2025-02-12 at 12 28 05 PM

@bgarciaentornos note that I'm not recommending this as a new feature. It's really just restoring functionality from Sakai 22. I think this is a classic 1% type of feature where it is used by only one program in one school. I think the right thing to do is restore the broken functionality and then hide the functionality via a Sakai property. Unless you have a direct use case for this functionality, I don't recommend it as a new feature.

@bgarciaentornos
Copy link
Contributor

I agree it's not widely used and not recommended or needed nowadays. Anyway, I think it's good to keep support for it, just wanted to see how it looked, thanks!

@ottenhoff
Copy link
Contributor Author

NP. do you know of anyone using it or looking for it? What do you think about disabling by default?

@bgarciaentornos
Copy link
Contributor

Not sure tbh, but I'm fine about disabling it by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants