Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache TRPC query for logs #1664

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from
Open

Cache TRPC query for logs #1664

wants to merge 2 commits into from

Conversation

krzysztofzuraw
Copy link
Member

Scope of the PR

  • Cached TRPC query for clientLogs.getByPspReference & clientLogs.getByDate. I decided to go with Next.js config headers as TRPC way (based on docs) didn't work on preview deployment.
  • Fixed how we send date via TRPC for clientLogs.getByDate. Previously we send seconds in request which in sense disables cache (on UI change new seconds will be send to TRPC). Now app will send 00 as seconds to enable 60s revalidate time. UI currently don't support persisting date / psp reference anyway.
  • Added new cache headers: CDN-Cache-Control with Cache-Control (based on Vercel documentation)

Related issues

Checklist

Copy link

changeset-bot bot commented Dec 30, 2024

🦋 Changeset detected

Latest commit: dcea48c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
app-avatax Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 7:31am
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 7:31am
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 7:31am
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 7:31am
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 7:31am
saleor-app-segment ✅ Ready (Inspect) Visit Preview Jan 7, 2025 7:31am
saleor-app-smtp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 7:31am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants