Skip to content

Fix AvaTax lint issues#1780

Merged
kzuraw merged 4 commits intomainfrom
fix-eslint-avatax
Mar 18, 2025
Merged

Fix AvaTax lint issues#1780
kzuraw merged 4 commits intomainfrom
fix-eslint-avatax

Conversation

@kzuraw
Copy link
Copy Markdown
Contributor

@kzuraw kzuraw commented Mar 18, 2025

Scope of the PR

Related issues

Checklist

@kzuraw kzuraw added the skip changeset Attach this label to PRs which does not need changes description for the release notes. label Mar 18, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: 8d743e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 10:29am
saleor-app-cms ✅ Ready (Inspect) Visit Preview Mar 18, 2025 10:29am
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 10:29am
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview Mar 18, 2025 10:29am
saleor-app-search ✅ Ready (Inspect) Visit Preview Mar 18, 2025 10:29am
saleor-app-segment ✅ Ready (Inspect) Visit Preview Mar 18, 2025 10:29am
saleor-app-smtp ✅ Ready (Inspect) Visit Preview Mar 18, 2025 10:29am

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 42.06349% with 73 lines in your changes missing coverage. Please review.

Project coverage is 43.88%. Comparing base (aa1c759) to head (8d743e2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/avatax/src/pages/api/webhooks/order-confirmed.ts 0.00% 22 Missing ⚠️
.../order-confirmed/avatax-order-confirmed-adapter.ts 0.00% 15 Missing ⚠️
...ax/src/pages/api/webhooks/order-calculate-taxes.ts 0.00% 15 Missing ⚠️
...onfirmed/avatax-order-confirmed-payload.service.ts 0.00% 11 Missing ⚠️
...onfirmed/avatax-order-confirmed-adapter-factory.ts 0.00% 6 Missing ⚠️
...s/avatax/src/pages/api/webhooks/order-cancelled.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1780      +/-   ##
==========================================
- Coverage   43.88%   43.88%   -0.01%     
==========================================
  Files         664      664              
  Lines      296464   296495      +31     
  Branches     2038     2038              
==========================================
+ Hits       130094   130107      +13     
- Misses     165948   165966      +18     
  Partials      422      422              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kzuraw kzuraw marked this pull request as ready for review March 18, 2025 07:26
@kzuraw kzuraw requested a review from a team March 18, 2025 07:26
Comment thread apps/avatax/.eslintrc.cjs
rules: {
"turbo/no-undeclared-env-vars": ["error"],
"node/no-process-env": ["error"],
"max-params": ["error", { max: 3 }],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this rule is really neat, I didn't know about this 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App: AvaTax skip changeset Attach this label to PRs which does not need changes description for the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants