Skip to content

Fix lint issues for segment & smtp apps #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

krzysztofzuraw
Copy link
Member

Scope of the PR

Related issues

Checklist

@krzysztofzuraw krzysztofzuraw added the skip changeset Attach this label to PRs which does not need changes description for the release notes. label Mar 18, 2025
Copy link

changeset-bot bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: b0fba90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview Mar 19, 2025 7:52am
saleor-app-cms ✅ Ready (Inspect) Visit Preview Mar 19, 2025 7:52am
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 7:52am
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview Mar 19, 2025 7:52am
saleor-app-search ✅ Ready (Inspect) Visit Preview Mar 19, 2025 7:52am
saleor-app-segment ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 7:52am
saleor-app-smtp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 7:52am

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 43.88%. Comparing base (ae59931) to head (b0fba90).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
apps/smtp/src/modules/trpc/trpc-client.ts 0.00% 4 Missing ⚠️
apps/smtp/src/modules/smtp/ui/code-editor.tsx 0.00% 2 Missing ⚠️
...ation/smtp/[configurationId]/event/[eventType].tsx 0.00% 2 Missing ⚠️
apps/smtp/src/lib/fetch-app-permissions.ts 0.00% 1 Missing ⚠️
...src/pages/configuration/smtp/[configurationId].tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1786      +/-   ##
==========================================
- Coverage   43.88%   43.88%   -0.01%     
==========================================
  Files         664      664              
  Lines      296493   296497       +4     
  Branches     2038     2038              
==========================================
  Hits       130107   130107              
- Misses     165964   165968       +4     
  Partials      422      422              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review March 18, 2025 15:07
@krzysztofzuraw krzysztofzuraw requested a review from a team as a code owner March 18, 2025 15:07
Comment on lines +6 to +10
"no-console": "error",
"@saleor/saleor-app/logger-leak": "error",
"max-params": ["error", { max: 3 }],
"@vitest/prefer-strict-equal": "error",
"@vitest/prefer-vi-mocked": "error",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why its not shared with eslint-plugin-saleor?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to migrate app by app - after I merge all PRs with lint issues fixes I will move those rules to eslint-plugin-saleor 😄

@krzysztofzuraw krzysztofzuraw merged commit d73a1a1 into main Mar 19, 2025
27 checks passed
@krzysztofzuraw krzysztofzuraw deleted the fix-lint-issues-smtp-segment branch March 19, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: Segment App: SMTP skip changeset Attach this label to PRs which does not need changes description for the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants