-
Notifications
You must be signed in to change notification settings - Fork 364
Fix lint issues for segment & smtp apps #1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1786 +/- ##
==========================================
- Coverage 43.88% 43.88% -0.01%
==========================================
Files 664 664
Lines 296493 296497 +4
Branches 2038 2038
==========================================
Hits 130107 130107
- Misses 165964 165968 +4
Partials 422 422 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
"no-console": "error", | ||
"@saleor/saleor-app/logger-leak": "error", | ||
"max-params": ["error", { max: 3 }], | ||
"@vitest/prefer-strict-equal": "error", | ||
"@vitest/prefer-vi-mocked": "error", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why its not shared with eslint-plugin-saleor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to migrate app by app - after I merge all PRs with lint issues fixes I will move those rules to eslint-plugin-saleor
😄
Scope of the PR
Related issues
Checklist