Skip to content

Cleanup monorepo deps #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 20, 2025
Merged

Cleanup monorepo deps #1790

merged 5 commits into from
Mar 20, 2025

Conversation

krzysztofzuraw
Copy link
Member

Scope of the PR

Cleanup deps, peerDeps & devDependencies for package

Related issues

Checklist

Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 3:10pm
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 3:10pm
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 3:10pm
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 3:10pm
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 3:10pm
saleor-app-segment ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 3:10pm
saleor-app-smtp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 3:10pm

Copy link

changeset-bot bot commented Mar 19, 2025

🦋 Changeset detected

Latest commit: 9eb4f57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@saleor/react-hook-form-macaw Patch
@saleor/eslint-config-apps Patch
@saleor/webhook-utils Patch
saleor-app-products-feed Patch
@saleor/apps-logger Patch
@saleor/apps-shared Patch
@saleor/apps-otel Patch
@saleor/trpc Patch
saleor-app-klaviyo Patch
saleor-app-segment Patch
@saleor/e2e Patch
saleor-app-avatax Patch
saleor-app-search Patch
@saleor/apps-ui Patch
saleor-app-smtp Patch
saleor-app-cms Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.87%. Comparing base (c0c540a) to head (9eb4f57).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apps/segment/next.config.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1790      +/-   ##
==========================================
- Coverage   43.87%   43.87%   -0.01%     
==========================================
  Files         664      664              
  Lines      296507   296508       +1     
  Branches     2038     2038              
==========================================
  Hits       130107   130107              
- Misses     165978   165979       +1     
  Partials      422      422              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Differences Found

✅ No packages or licenses were added.

Summary

Expand
License Name Package Count Packages
0BSD 1
Packages
  • tslib
CC BY-SA 4.0 1
Packages
  • @cspell/dict-en-common-misspellings
CC-BY-3.0 1
Packages
  • spdx-exceptions
GPL-3.0 1
Packages
  • store2
MIT (http://mootools.net/license.txt) 1
Packages
  • slick
MPL-2.0 1
Packages
  • axe-core
Public Domain 1
Packages
  • jsonify
Python-2.0 1
Packages
  • argparse
SEE LICENSE IN LICENSE.md 1
Packages
  • lightcookie
WTFPL 1
Packages
  • opener
CC-BY-4.0 2
Packages
  • @saleor/macaw-ui
  • caniuse-lite
Unlicense 2
Packages
  • @sinonjs/text-encoding
  • big-integer
BlueOak-1.0.0 3
Packages
  • jackspeak
  • package-json-from-dist
  • path-scurry
CC0-1.0 3
Packages
  • language-subtag-registry
  • spdx-license-ids
  • type-fest
<<missing>> 4
Packages
  • bruno
  • busboy
  • json-query
  • streamsearch
BSD-2-Clause 31
Packages
  • @base2/pretty-print-object
  • @typescript-eslint/parser
  • @typescript-eslint/typescript-estree
  • @yarnpkg/esbuild-plugin-pnp
  • cheerio-select
  • css-select
  • css-what
  • damerau-levenshtein
  • domelementtype
  • domhandler
  • domutils
  • dotenv
  • dotenv-expand
  • entities
  • escodegen
  • eslint-scope
  • espree
  • esprima
  • esrecurse
  • estraverse
  • And 11 more...
BSD-3-Clause 53
Packages
  • @humanwhocodes/object-schema
  • @protobufjs/aspromise
  • @protobufjs/base64
  • @protobufjs/codegen
  • @protobufjs/eventemitter
  • @protobufjs/fetch
  • @protobufjs/float
  • @protobufjs/inquire
  • @protobufjs/path
  • @protobufjs/pool
  • @protobufjs/utf8
  • @saleor/eslint-plugin-saleor-app
  • @sentry/cli
  • @sentry/cli-darwin
  • @sentry/cli-linux-arm
  • @sentry/cli-linux-arm64
  • @sentry/cli-linux-i686
  • @sentry/cli-linux-x64
  • @sentry/cli-win32-i686
  • @sentry/cli-win32-x64
  • And 33 more...
ISC 72
Packages
  • @isaacs/cliui
  • @istanbuljs/load-nyc-config
  • @saleor/app-sdk
  • @ungap/structured-clone
  • abbrev
  • ansi-align
  • anymatch
  • aproba
  • are-we-there-yet
  • ast-types-flow
  • boolbase
  • c8
  • chownr
  • cli-width
  • cliui
  • color-support
  • concat-with-sourcemaps
  • console-control-strings
  • electron-to-chromium
  • eslint-import-resolver-typescript
  • And 52 more...
Apache-2.0 195
Packages
  • @ampproject/remapping
  • @aws-crypto/crc32
  • @aws-crypto/crc32c
  • @aws-crypto/ie11-detection
  • @aws-crypto/sha1-browser
  • @aws-crypto/sha256-browser
  • @aws-crypto/sha256-js
  • @aws-crypto/supports-web-crypto
  • @aws-crypto/util
  • @aws-sdk/abort-controller
  • @aws-sdk/chunked-blob-reader
  • @aws-sdk/client-dynamodb
  • @aws-sdk/client-s3
  • @aws-sdk/client-sso
  • @aws-sdk/client-sso-oidc
  • @aws-sdk/client-sts
  • @aws-sdk/config-resolver
  • @aws-sdk/core
  • @aws-sdk/credential-provider-env
  • @aws-sdk/credential-provider-http
  • And 175 more...
MIT 1689
Packages
  • @0no-co/graphql.web
  • @algolia/cache-browser-local-storage
  • @algolia/cache-common
  • @algolia/cache-in-memory
  • @algolia/client-account
  • @algolia/client-analytics
  • @algolia/client-common
  • @algolia/client-personalization
  • @algolia/client-search
  • @algolia/logger-common
  • @algolia/logger-console
  • @algolia/recommend
  • @algolia/requester-browser-xhr
  • @algolia/requester-common
  • @algolia/requester-node-http
  • @algolia/transporter
  • @ardatan/relay-compiler
  • @ardatan/sync-fetch
  • @arr/every
  • @aw-web-design/x-default-browser
  • And 1669 more...

@vercel vercel bot temporarily deployed to Preview – saleor-app-search March 19, 2025 13:39 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-cms March 19, 2025 13:39 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-segment March 19, 2025 13:39 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-smtp March 19, 2025 13:39 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-avatax March 19, 2025 13:39 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-products-feed March 19, 2025 13:39 Inactive
lkostrowski
lkostrowski previously approved these changes Mar 19, 2025
@@ -56,7 +56,6 @@ const nextConfig = {
"@saleor/app-sdk",
"@trpc/server",
"@trpc/client",
"@trpc/react-query",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out we need that for trpc to work properly - I bringed it back at 9eb4f57 (#1790)

@krzysztofzuraw krzysztofzuraw merged commit da9899d into main Mar 20, 2025
32 checks passed
@krzysztofzuraw krzysztofzuraw deleted the cleanup-deps branch March 20, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants