Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sentry dropping internal OTEL spans #1803

Merged
merged 4 commits into from
Mar 24, 2025
Merged

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented Mar 21, 2025

Scope of the PR

Fix how we initialize Sentry SDK for API routes when using node.js runtime. After this change we will use NodeClient from Sentry directly - avoiding Sentry interference with our OTEL setup.

Related issues

Checklist

Copy link

changeset-bot bot commented Mar 21, 2025

🦋 Changeset detected

Latest commit: 2c6421d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-app-avatax Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 7:00am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
saleor-app-cms ⬜️ Skipped (Inspect) 💬 Add feedback Mar 24, 2025 7:00am
saleor-app-klaviyo ⬜️ Skipped (Inspect) Mar 24, 2025 7:00am
saleor-app-products-feed ⬜️ Skipped (Inspect) 💬 Add feedback Mar 24, 2025 7:00am
saleor-app-search ⬜️ Skipped (Inspect) 💬 Add feedback Mar 24, 2025 7:00am
saleor-app-segment ⬜️ Skipped (Inspect) 💬 Add feedback Mar 24, 2025 7:00am
saleor-app-smtp ⬜️ Skipped (Inspect) 💬 Add feedback Mar 24, 2025 7:00am

Copy link
Contributor

Differences Found

✅ No packages or licenses were added.

Summary

Expand
License Name Package Count Packages
0BSD 1
Packages
  • tslib
CC BY-SA 4.0 1
Packages
  • @cspell/dict-en-common-misspellings
CC-BY-3.0 1
Packages
  • spdx-exceptions
GPL-3.0 1
Packages
  • store2
MIT (http://mootools.net/license.txt) 1
Packages
  • slick
MPL-2.0 1
Packages
  • axe-core
Public Domain 1
Packages
  • jsonify
Python-2.0 1
Packages
  • argparse
SEE LICENSE IN LICENSE.md 1
Packages
  • lightcookie
WTFPL 1
Packages
  • opener
CC-BY-4.0 2
Packages
  • @saleor/macaw-ui
  • caniuse-lite
Unlicense 2
Packages
  • @sinonjs/text-encoding
  • big-integer
BlueOak-1.0.0 3
Packages
  • jackspeak
  • package-json-from-dist
  • path-scurry
CC0-1.0 3
Packages
  • language-subtag-registry
  • spdx-license-ids
  • type-fest
<<missing>> 4
Packages
  • bruno
  • busboy
  • json-query
  • streamsearch
BSD-2-Clause 31
Packages
  • @base2/pretty-print-object
  • @typescript-eslint/parser
  • @typescript-eslint/typescript-estree
  • @yarnpkg/esbuild-plugin-pnp
  • cheerio-select
  • css-select
  • css-what
  • damerau-levenshtein
  • domelementtype
  • domhandler
  • domutils
  • dotenv
  • dotenv-expand
  • entities
  • escodegen
  • eslint-scope
  • espree
  • esprima
  • esrecurse
  • estraverse
  • And 11 more...
BSD-3-Clause 53
Packages
  • @humanwhocodes/object-schema
  • @protobufjs/aspromise
  • @protobufjs/base64
  • @protobufjs/codegen
  • @protobufjs/eventemitter
  • @protobufjs/fetch
  • @protobufjs/float
  • @protobufjs/inquire
  • @protobufjs/path
  • @protobufjs/pool
  • @protobufjs/utf8
  • @saleor/eslint-plugin-saleor-app
  • @sentry/cli
  • @sentry/cli-darwin
  • @sentry/cli-linux-arm
  • @sentry/cli-linux-arm64
  • @sentry/cli-linux-i686
  • @sentry/cli-linux-x64
  • @sentry/cli-win32-i686
  • @sentry/cli-win32-x64
  • And 33 more...
ISC 73
Packages
  • @isaacs/cliui
  • @istanbuljs/load-nyc-config
  • @saleor/app-sdk
  • @ungap/structured-clone
  • abbrev
  • ansi-align
  • anymatch
  • aproba
  • are-we-there-yet
  • ast-types-flow
  • boolbase
  • c8
  • chownr
  • cli-width
  • cliui
  • color-support
  • concat-with-sourcemaps
  • console-control-strings
  • electron-to-chromium
  • eslint-import-resolver-typescript
  • And 53 more...
Apache-2.0 219
Packages
  • @ampproject/remapping
  • @aws-crypto/crc32
  • @aws-crypto/crc32c
  • @aws-crypto/ie11-detection
  • @aws-crypto/sha1-browser
  • @aws-crypto/sha256-browser
  • @aws-crypto/sha256-js
  • @aws-crypto/supports-web-crypto
  • @aws-crypto/util
  • @aws-sdk/abort-controller
  • @aws-sdk/chunked-blob-reader
  • @aws-sdk/client-dynamodb
  • @aws-sdk/client-s3
  • @aws-sdk/client-sso
  • @aws-sdk/client-sso-oidc
  • @aws-sdk/client-sts
  • @aws-sdk/config-resolver
  • @aws-sdk/core
  • @aws-sdk/credential-provider-env
  • @aws-sdk/credential-provider-http
  • And 199 more...
MIT 1697
Packages
  • @0no-co/graphql.web
  • @algolia/cache-browser-local-storage
  • @algolia/cache-common
  • @algolia/cache-in-memory
  • @algolia/client-account
  • @algolia/client-analytics
  • @algolia/client-common
  • @algolia/client-personalization
  • @algolia/client-search
  • @algolia/logger-common
  • @algolia/logger-console
  • @algolia/recommend
  • @algolia/requester-browser-xhr
  • @algolia/requester-common
  • @algolia/requester-node-http
  • @algolia/transporter
  • @ardatan/relay-compiler
  • @ardatan/sync-fetch
  • @arr/every
  • @aw-web-design/x-default-browser
  • And 1677 more...

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 43.89%. Comparing base (6a3d5f7) to head (2c6421d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apps/avatax/src/instrumentations/sentry-node.ts 0.00% 23 Missing and 1 partial ⚠️
apps/avatax/src/instrumentation.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1803   +/-   ##
=======================================
  Coverage   43.88%   43.89%           
=======================================
  Files         663      664    +1     
  Lines      296468   296432   -36     
  Branches     2037     2038    +1     
=======================================
  Hits       130106   130106           
+ Misses     165941   165904   -37     
- Partials      421      422    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel vercel bot temporarily deployed to Preview – saleor-app-klaviyo March 24, 2025 06:57 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-search March 24, 2025 06:57 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-cms March 24, 2025 06:57 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-segment March 24, 2025 06:57 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-products-feed March 24, 2025 06:57 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-smtp March 24, 2025 06:57 Inactive
@krzysztofzuraw krzysztofzuraw changed the title fix missing spans when using sentry Fix Sentry dropping internal OTEL spans Mar 24, 2025
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review March 24, 2025 06:58
@krzysztofzuraw krzysztofzuraw requested a review from a team as a code owner March 24, 2025 06:58
@krzysztofzuraw krzysztofzuraw merged commit cc32891 into main Mar 24, 2025
25 of 26 checks passed
@krzysztofzuraw krzysztofzuraw deleted the sentry-missing-spans branch March 24, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants