Skip to content

Create github-releases-to-discord.yml #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

peelar
Copy link
Member

@peelar peelar commented Mar 27, 2025

Scope of the PR

I added the same workflow we use in saleor/saleor for announcing releases on Discord. It provides a nicely formatted message.

TODO:

  • Remove current #releases workflow for apps

TODO:
- Add Webhook URL @patrys 
- Remove current #releases workflow for apps
@peelar peelar self-assigned this Mar 27, 2025
Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: 9c4f6d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 1:29pm
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 1:29pm
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 1:29pm
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 1:29pm
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 1:29pm
saleor-app-segment ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 1:29pm
saleor-app-smtp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 1:29pm

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.83%. Comparing base (6ec72fa) to head (9c4f6d9).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1822   +/-   ##
=======================================
  Coverage   43.83%   43.83%           
=======================================
  Files         671      671           
  Lines      297289   297289           
  Branches     2046     2046           
=======================================
  Hits       130328   130328           
  Misses     166534   166534           
  Partials      427      427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

with:
webhook_url: ${{ secrets.DISCORD_WEBHOOK_URL }}
color: "11155626"
content: "New Saleor Apps release!"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Can we test it first? When we release apps we in many cases release then in bulk (e.g because underlying package was updated) and I'm wondering how it will look like in Discord? Also let say I update @saleor/apps-logger and it updates saleor-app-avatax - will I see two apps releases? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, that's a good point. There is quite a lot of apps and packages here and most of the changelogs are not something Discord users would be interested in. Maybe we could filter it to only inform about app-related (so no packages) minor releases. Do you think it would make sense @krzysztofzuraw? cc @patrys

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can start with filtering and see how it goes 👍🏻

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why even announce updates/roll releases if it's not something users care about?

Copy link
Member Author

@peelar peelar Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, closing it. We will be informing of big app releases "manually"

@peelar peelar closed this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Attach this label to PRs which does not need changes description for the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants