-
Notifications
You must be signed in to change notification settings - Fork 364
Create github-releases-to-discord.yml #1822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TODO: - Add Webhook URL @patrys - Remove current #releases workflow for apps
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1822 +/- ##
=======================================
Coverage 43.83% 43.83%
=======================================
Files 671 671
Lines 297289 297289
Branches 2046 2046
=======================================
Hits 130328 130328
Misses 166534 166534
Partials 427 427 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
with: | ||
webhook_url: ${{ secrets.DISCORD_WEBHOOK_URL }} | ||
color: "11155626" | ||
content: "New Saleor Apps release!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Can we test it first? When we release apps we in many cases release then in bulk (e.g because underlying package
was updated) and I'm wondering how it will look like in Discord? Also let say I update @saleor/apps-logger
and it updates saleor-app-avatax
- will I see two apps releases? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, that's a good point. There is quite a lot of apps and packages here and most of the changelogs are not something Discord users would be interested in. Maybe we could filter it to only inform about app-related (so no packages) minor releases. Do you think it would make sense @krzysztofzuraw? cc @patrys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can start with filtering and see how it goes 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why even announce updates/roll releases if it's not something users care about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, closing it. We will be informing of big app releases "manually"
Scope of the PR
I added the same workflow we use in saleor/saleor for announcing releases on Discord. It provides a nicely formatted message.
TODO: