Add new eslint rule#2370
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: a345b05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shared @saleor/eslint-config-apps flat ESLint configuration to include eslint-plugin-depend and enables the depend/ban-dependencies rule to flag imports of redundant packages in the monorepo.
Changes:
- Added
eslint-plugin-dependto the ESLint config package dependencies and lockfile. - Enabled the
depend/ban-dependenciesrule forjs/ts/tsxfiles in the shared flat config. - Added a changeset to version the eslint-config package for this rule addition.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pnpm-lock.yaml |
Locks eslint-plugin-depend and its transitive dependencies. |
packages/eslint-config/package.json |
Adds eslint-plugin-depend@1.5.0 to the eslint-config package. |
packages/eslint-config/index.js |
Registers the depend plugin and enables depend/ban-dependencies for JS/TS/TSX. |
.changeset/add-eslint-plugin-depend.md |
Declares a version bump and documents the new lint rule behavior. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Contributor
Differences FoundExpandLicense Package MIT empathic MIT eslint-plugin-depend MIT module-replacements SummaryExpand
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2370 +/- ##
=======================================
Coverage 38.15% 38.15%
=======================================
Files 1048 1048
Lines 67116 67116
Branches 3598 3598
=======================================
Hits 25605 25605
Misses 41121 41121
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…eor/apps into lkostrowski/add-eslint-plugin-depend
wcislo-saleor
left a comment
wcislo-saleor
left a comment
Member
There was a problem hiding this comment.
Except for misleading changeset text it's fine.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
przlada
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of the PR
Related issues
Checklist