Skip to content

ENG-1670 Use full gift card code in sent email template#2383

Merged
magul merged 2 commits into
mainfrom
ENG-1670-full-code-for-gift-card
Jun 29, 2026
Merged

ENG-1670 Use full gift card code in sent email template#2383
magul merged 2 commits into
mainfrom
ENG-1670-full-code-for-gift-card

Conversation

@magul

@magul magul commented Jun 24, 2026

Copy link
Copy Markdown
Member

The default "Gift card sent" template rendered giftCard.displayCode, which Saleor returns masked (last 4 chars only), so customers received an unusable code. Switch to giftCard.code to show the full, redeemable code. The field is already fetched in the webhook fragment, so no schema/codegen change is needed.

The default "Gift card sent" template rendered `giftCard.displayCode`,
which Saleor returns masked (last 4 chars only), so customers received
an unusable code. Switch to `giftCard.code` to show the full,
redeemable code. The field is already fetched in the webhook fragment,
so no schema/codegen change is needed.
@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dummy-payment-app Ready Ready Preview, Comment Jun 29, 2026 2:11pm
saleor-app-anonymizer Ready Ready Preview, Comment Jun 29, 2026 2:11pm
saleor-app-onboarding Ready Ready Preview, Comment Jun 29, 2026 2:11pm
9 Skipped Deployments
Project Deployment Actions Updated (UTC)
saleor-app-avatax Ignored Ignored Preview, Comment Jun 29, 2026 2:11pm
saleor-app-cms Ignored Ignored Preview, Comment Jun 29, 2026 2:11pm
saleor-app-klaviyo Ignored Ignored Preview Jun 29, 2026 2:11pm
saleor-app-payment-np-atobarai Ignored Ignored Preview, Comment Jun 29, 2026 2:11pm
saleor-app-payment-stripe Ignored Ignored Preview Jun 29, 2026 2:11pm
saleor-app-products-feed Ignored Ignored Preview, Comment Jun 29, 2026 2:11pm
saleor-app-search Ignored Ignored Preview, Comment Jun 29, 2026 2:11pm
saleor-app-segment Ignored Ignored Preview, Comment Jun 29, 2026 2:11pm
saleor-app-smtp Ignored Ignored Preview, Comment Jun 29, 2026 2:11pm

Request Review

@changeset-bot

changeset-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2e7ae4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-app-smtp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.15%. Comparing base (6412aa6) to head (2e7ae4e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2383   +/-   ##
=======================================
  Coverage   38.15%   38.15%           
=======================================
  Files        1048     1048           
  Lines       67116    67116           
  Branches     3598     3598           
=======================================
  Hits        25605    25605           
  Misses      41121    41121           
  Partials      390      390           
Flag Coverage Δ
avatax 57.58% <ø> (ø)
cms 21.85% <ø> (ø)
domain 100.00% <ø> (ø)
dynamo-config-repository 79.29% <ø> (ø)
errors 92.00% <ø> (ø)
logger 28.81% <ø> (ø)
np-atobarai 72.66% <ø> (ø)
products-feed 6.01% <ø> (ø)
search 32.31% <ø> (ø)
segment 33.65% <ø> (ø)
shared 56.07% <ø> (ø)
smtp 36.32% <100.00%> (ø)
stripe 70.89% <ø> (ø)
webhook-utils 21.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@magul magul changed the title INFRA-1670 Use full gift card code in sent email template ENG-1670 Use full gift card code in sent email template Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants