Skip to content

build: switch labeller to pull_request event#2388

Merged
NyanKiyoshi merged 1 commit into
mainfrom
build/switch-pull_request_target
Jun 29, 2026
Merged

build: switch labeller to pull_request event#2388
NyanKiyoshi merged 1 commit into
mainfrom
build/switch-pull_request_target

Conversation

@NyanKiyoshi

Copy link
Copy Markdown
Member

pull_request_target is not really needed in our context as we do not really receive any external contribution (other than bots/agents)

Thus, this doesn't warrant the risks that pull_request_target exposes Saleor to

Checklist

`pull_request_target` is not really needed in our context as we do not really receive any external contribution (other than bots/agents)

Thus, this doesn't warrant the risks that `pull_request_target` exposes Saleor to
@NyanKiyoshi NyanKiyoshi self-assigned this Jun 29, 2026
@NyanKiyoshi NyanKiyoshi requested a review from a team as a code owner June 29, 2026 14:25
@NyanKiyoshi NyanKiyoshi requested a review from magul June 29, 2026 14:25
@NyanKiyoshi NyanKiyoshi added the skip changeset Attach this label to PRs which does not need changes description for the release notes. label Jun 29, 2026
@changeset-bot

changeset-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 18bd734

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dummy-payment-app Ready Ready Preview, Comment Jun 29, 2026 2:28pm
saleor-app-anonymizer Ready Ready Preview, Comment Jun 29, 2026 2:28pm
saleor-app-avatax Ready Ready Preview, Comment Jun 29, 2026 2:28pm
saleor-app-cms Ready Ready Preview, Comment Jun 29, 2026 2:28pm
saleor-app-klaviyo Ready Ready Preview, Comment Jun 29, 2026 2:28pm
saleor-app-onboarding Ready Ready Preview, Comment Jun 29, 2026 2:28pm
saleor-app-payment-np-atobarai Ready Ready Preview, Comment Jun 29, 2026 2:28pm
saleor-app-payment-stripe Ready Ready Preview, Comment Jun 29, 2026 2:28pm
saleor-app-products-feed Ready Ready Preview, Comment Jun 29, 2026 2:28pm
saleor-app-search Ready Ready Preview, Comment Jun 29, 2026 2:28pm
saleor-app-segment Ready Ready Preview, Comment Jun 29, 2026 2:28pm
saleor-app-smtp Ready Ready Preview, Comment Jun 29, 2026 2:28pm

Request Review

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@686ff4d). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2388   +/-   ##
=======================================
  Coverage        ?   38.15%           
=======================================
  Files           ?     1048           
  Lines           ?    67116           
  Branches        ?     3598           
=======================================
  Hits            ?    25605           
  Misses          ?    41121           
  Partials        ?      390           
Flag Coverage Δ
avatax 57.58% <ø> (?)
cms 21.85% <ø> (?)
domain 100.00% <ø> (?)
dynamo-config-repository 79.29% <ø> (?)
errors 92.00% <ø> (?)
logger 28.81% <ø> (?)
np-atobarai 72.66% <ø> (?)
products-feed 6.01% <ø> (?)
search 32.31% <ø> (?)
segment 33.65% <ø> (?)
shared 56.07% <ø> (?)
smtp 36.32% <ø> (?)
stripe 70.89% <ø> (?)
webhook-utils 21.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NyanKiyoshi NyanKiyoshi merged commit 04db8f5 into main Jun 29, 2026
58 checks passed
@NyanKiyoshi NyanKiyoshi deleted the build/switch-pull_request_target branch June 29, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Attach this label to PRs which does not need changes description for the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants