Add Segment app docs #1435
Merged
Add Segment app docs #1435
+108
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
witoszekdev
reviewed
Jan 20, 2025
Comment on lines
45
to
47
| - Order `id` in base64 format | ||
| - User information: | ||
| - User `id` in base64 format |
There was a problem hiding this comment.
question: Is this exactly Order.id from Saleor or do we do some additional base64 encoding?
I'm wondering if we should even mention it's base64, since it can change at any time, because Saleor didn't guarantee that it will use this specific format and we definitely don't want to recommend users to decode that base64 because they will start depending on it.
There was a problem hiding this comment.
exactly Order.id 😄
Good question - maybe just Order.id is enough - I will change it
There was a problem hiding this comment.
Done in 572718b (#1435)
lkostrowski
previously approved these changes
Jan 20, 2025
lkostrowski
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.