-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add order list for logged user #1011
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Could you rebase @zaiste ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace slate
with neutral
src/app/(main)/orders/page.tsx
Outdated
export default function OrderPage() { | ||
const OrderList = dynamic(() => import("../../../ui/components/OrderList"), { ssr: false }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be outside the component body?
export default function OrderPage() { | |
const OrderList = dynamic(() => import("../../../ui/components/OrderList"), { ssr: false }); | |
const OrderList = dynamic(() => import("../../../ui/components/OrderList").then((m) => m.OrderList), { ssr: false }); | |
export default function OrderPage() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmiszy named export doesn't work unfortunately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does work, we're already using it in other places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed there's a bug in Next.js :D Adding "use client" to the page.tsx
fixes it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D
Yeah, but I'd prefer not to set the entire page as client
. Let's keep it as default
for now with an eslint exception, there's an open bug report in the Next.js repo, let's track it and fix it once it's done upstream. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole page is client anyway because you're only rendering a single dynamic component.
No description provided.