Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add channel slug to URLs #1046

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Add channel slug to URLs #1046

merged 2 commits into from
Nov 27, 2023

Conversation

typeofweb
Copy link
Contributor

Fixes #1029

@typeofweb typeofweb requested a review from zaiste November 27, 2023 13:40
@vercel Vercel
Copy link

vercel bot commented Nov 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
storefront ✅ Ready (Inspect) Visit Preview Nov 27, 2023 2:21pm

@zaiste
Copy link
Contributor

zaiste commented Nov 27, 2023

@mmiszy default-channel doesn't have to be visible in the pathname.

grzegorzpokorski
grzegorzpokorski reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@grzegorzpokorski grzegorzpokorski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but we should also add a channel in the redirection on the search page and in the SearchBar component if the default channel have to be visible in URL.

@grzegorzpokorski
Copy link
Contributor

grzegorzpokorski commented Nov 27, 2023 •
edited
Loading

@mmiszy CheckoutLink on the /cart page also lacks a channel in the href. Perhaps a good solution would be a middleware that adds a default channel to the links in situations where it doesn't have a channel in the pathname?

@typeofweb
Copy link
Contributor Author

@grzegorzpokorski CheckoutLink doesn't need a channel.

@typeofweb typeofweb merged commit 5dc219e into main Nov 27, 2023
3 checks passed
@typeofweb typeofweb deleted the parameterize-queries branch November 27, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzegorzpokorski grzegorzpokorski grzegorzpokorski left review comments

@zaiste zaiste Awaiting requested review from zaiste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass current channel in URL
3 participants
@typeofweb @zaiste @grzegorzpokorski