Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix # - VAT Values display incorrectly on Quotes->Service Line Items, if Significant Figures = 0 #10441

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

serhiisamko091184
Copy link
Contributor

Description

When the user sets their Significant Digits to 0 (via their Profile)

When viewing the Quotes detailview, any "0" values are stripped, leading to displaying errors

ie:
"0%" becomes "%"
"20%" becomes "2%"

Motivation and Context

How To Test This

  1. Set sign digits to 0 in settings: Profile -> Advanced Tab -> .
  2. Go to Quotes module -> Create quote -> add service line
  3. Check tax column on DetailView:
    image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants