Fix #10446 - Resolve issue preventing link creation in Security Groups sub-panels #10447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…curity Groups sub-panels This commit addresses an issue where related custom module items couldn't be selected via sub-panels. The problem occurred when the bean with the relationship link property was empty and not an instance of Link2. The root cause was identified within the Link2 class's add() function, specifically when the getSide() method returns 'RHS'. This situation arose when either the 'RHS' or 'LHS' was set to 'SecurityGroup' in the M2MRelationship add() function.
|
Hello @gaspare-joubert, thanks for your contribution! Regards, |
serhiisamko091184
added
Branch:Hotfix
Area:Relationships
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit addresses an issue where related custom module items couldn't be selected via sub-panels. The problem occurred when the bean with the relationship link property was empty and not an instance of Link2.
The root cause was identified within the Link2 class's add() function, specifically when the getSide() method returns 'RHS'. This situation arose when either the 'RHS' or 'LHS' was set to 'SecurityGroup' in the M2MRelationship add() function.
Motivation and Context
This will fix a bug where you are unable to make selections using Security Groups sub-panels.
How To Test This
1.Open the Security groups module ui
2.Use the 'Create' button's 'Select' option on any custom module
3.In the pop-up window select a single or multiple options using the checkbox
4.Click 'Select'
Types of changes
Final checklist