Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10069 - Fix issue with workflow/report conditions not saving values when moving between modules #10534

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

JackBuchanan
Copy link
Contributor

Add functionality to loop through relationship path to pass in correct module to fixUpFormatting

Description

Add in new loop that goes through the relationship path (e.g. Accounts->Contacts->Calls) so that the correct module is passed into fixUpFormatting.

Previously the report/workflow base module is always passed into this function and if the relationship has a custom field that does not exist (e.g. Accounts->Contacts->Calls:custom_date)

Based off of fix: #10070 and expanded to cover reports and additional relationships

Credit to user https://github.com/re8260 for the initial fix.

Motivation and Context

Fixes issues with date fields from related modules not saving

How To Test This

Use steps from issue #10069

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

…t saving values when moving between modules

Add functionality to loop through relationship path to pass in correct module to fixUpFormatting
@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix PR 4-8 Score given to PRs once assessed labels Oct 1, 2024
@serhiisamko091184
Copy link
Contributor

Hello @JackBuchanan!

Thanks for your PR!

Regards,
Serhii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants