Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10543 - Remove Security Groups button on subpanelsbased on EditView #10544

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

SinergiaCRM
Copy link
Contributor

Description

Fixing bug #10543
Remove Security Group button was being displayed or hidden depending on permission on list and not edit.

Motivation and Context

The behavior between the remove button in the subpanel and removing groups from list view was not consistent.

How To Test This

1.Create a user U1
2.Create a security group SG1
3.Create a Role R1 and assign group permission on every action of every module
4.Assign SG1 and R1 to U1
5.Login with user U1 and check that it can not see the remove button on the subpanels
6. Change permission for R1 on Edit Security Groups and check that now the button is shown.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@serhiisamko091184 serhiisamko091184 added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Severity: Moderate Key function failed, but no or little impact PR 4-8 Score given to PRs once assessed Branch:Hotfix Status: Requires Code Review Needs the core team to code review and removed Severity: Moderate Key function failed, but no or little impact labels Oct 14, 2024
@serhiisamko091184
Copy link
Contributor

Hi @SinergiaCRM

thanks again for contributing!

Regards,
Serhii

@jack7anderson7 jack7anderson7 added Status: Passed Code Review Mark issue has passed code review reviewed Status: Requires Testing Requires Manual Testing and removed Status: Requires Code Review Needs the core team to code review labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Requires Testing Requires Manual Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants