Convert invalid hyphens to underscores for Android #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158.
According to the Android developers I work with, hyphens (-) are not valid in resource identifier names. I wasn't able to find an official, specific source verifying this, however, I noted that none of the resource examples https://developer.android.com/guide/topics/resources/providing-resources showed hyphens, while many showed underscores (_).
This answer on StackOverflow states that Android resource identifier names must conform to the rules for Java identifiers, which are restricted to letters, digits, underscore, and dollar sign:
My implementation approach is to specifically address hyphens as a common input and directly convert them to underscores in an attempt to preserve authorial intent. See #160
Normally, I would have added a test case for something like this, but see #161.