chore: minor TS adjustments @W-20496487 #5647
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I enabled `isolatedDeclarations` and fixed everything that made sense. Fully enabling the flag requires creating explicit types for the error info objects in `@lwc/errors`, which would be tedious, so I skipped that and disabled the flag. I enabled `isolatedModules` and fixed everything that made sense. We can't use `const enum` with isolated modules, but we like them because they minify cleanly, so I skipped that and disabled the flag. I enabled `erasableSyntaxOnly` and fixed everything that made sense. We can't use `const enum` with isolated modules, but we like them because they minify cleanly, so I skipped that and disabled the flag. (I did replace our regular `enum` with objects.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I enabled
isolatedDeclarationsand fixed everything that made sense. Fully enabling the flag requires creating explicit types for the error info objects in@lwc/errors, which would be tedious, so I skipped that and disabled the flag.I enabled
isolatedModulesand fixed everything that made sense. We can't useconst enumwith isolated modules, but we like them because they minify cleanly, so I skipped that and disabled the flag.I enabled
erasableSyntaxOnlyand fixed everything that made sense. We can't useconst enumwith isolated modules, but we like them because they minify cleanly, so I skipped that and disabled the flag. (I did replace our regularenumwith objects.)