Skip to content

[DO NOT MERGE] Trigger CI for #5657: feat: add specific error message for reserved keywords #5667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wjhsf wants to merge 2 commits into from
+16 −4
Closed

[DO NOT MERGE] Trigger CI for #5657: feat: add specific error message for reserved keywords #5667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad7de11
feat: add specific error message for reserved keywords
yashwanthvanama Dec 20, 2025
2367469
feat: updated the express.ts to do the isReservedES6Keyword only once
yashwanthvanama Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@lwc/errors/src/compiler/error-info/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
*/
/**
* Next error code: 1211
* Next error code: 1212
*/

export * from './compiler';
Expand Down
7 changes: 7 additions & 0 deletions packages/@lwc/errors/src/compiler/error-info/template-transform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,4 +1020,11 @@ export const ParserDiagnostics = {
level: DiagnosticLevel.Error,
url: '',
},

RESERVED_KEYWORD_AS_IDENTIFIER: {
code: 1211,
message: '{0} is a reserved keyword and cannot be used as an identifier.',
level: DiagnosticLevel.Error,
url: '',
},
} as const satisfies Record<string, LWCErrorInfo>;
4 changes: 2 additions & 2 deletions ...s/@lwc/template-compiler/src/__tests__/fixtures/expression/reverved-keyword/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
}
},
{
"code": 1059,
"message": "LWC1059: const is not a valid identifier",
"code": 1211,
"message": "LWC1211: const is a reserved keyword and cannot be used as an identifier.",
"level": 1,
"location": {
"line": 3,
Expand Down
7 changes: 6 additions & 1 deletion packages/@lwc/template-compiler/src/parser/expression.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,12 @@ export function parseIdentifier(
isValid = isIdentifierChar(source.charCodeAt(i));
}

if (isValid && !isReservedES6Keyword(source)) {
if (isValid) {
if (isReservedES6Keyword(source)) {
ctx.throwAtLocation(ParserDiagnostics.RESERVED_KEYWORD_AS_IDENTIFIER, location, [
source,
]);
}
return {
...t.identifier(source),
location,
Expand Down